Commit 46dfc3a5 authored May 21, 2019 by Tan, Tee Min Committed by David S. Miller May 20, 2019

net: stmmac: fix ethtool flow control not able to get/set



Currently ethtool was not able to get/set the flow control due to a
missing "!". It will always return -EOPNOTSUPP even the device is
flow control supported.

This patch fixes the condition check for ethtool flow control get/set
function for ETHTOOL_LINK_MODE_Asym_Pause_BIT.

Fixes: 3c1bcc86 (“net: ethernet: Convert phydev advertize and supported from u32 to link mode”)
Signed-off-by: Tan, Tee Min <tee.min.tan@intel.com>
Reviewed-by: Ong Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: Voon, Weifeng <weifeng.voon@intel.com@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7036e621

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -460,7 +460,7 @@ stmmac_get_pauseparam(struct net_device *netdev,
		} else {
		if (!linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
		netdev->phydev->supported) \|\|
		linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
		!linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
		netdev->phydev->supported))
		return;
		}
		@@ -491,7 +491,7 @@ stmmac_set_pauseparam(struct net_device *netdev,
		} else {
		if (!linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
		phy->supported) \|\|
		linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
		!linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
		phy->supported))
		return -EOPNOTSUPP;
		}

Admin message