Commit 46cce19b authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf trace: Beautify pipe2 'flags' arg 

 4.234 (0.005 ms): fetchmail/3224 pipe2(fildes: 0x7fffc72bcee0, flags: CLOEXEC) = 0

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-9e1jz78i6q6e0xr9fsitqbpe@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 07120aa5

tools/perf/builtin-trace.c

+25 −0
Original line number Diff line number Diff line
@@ -517,6 +517,29 @@ static size_t syscall_arg__scnprintf_eventfd_flags(char *bf, size_t size, 


#define SCA_EFD_FLAGS syscall_arg__scnprintf_eventfd_flags



static size_t syscall_arg__scnprintf_pipe_flags(char *bf, size_t size,

						struct syscall_arg *arg)

{

	int printed = 0, flags = arg->val;



#define	P_FLAG(n) \

	if (flags & O_##n) { \

		printed += scnprintf(bf + printed, size - printed, "%s%s", printed ? "|" : "", #n); \

		flags &= ~O_##n; \

	}



	P_FLAG(CLOEXEC);

	P_FLAG(NONBLOCK);

#undef P_FLAG



	if (flags)

		printed += scnprintf(bf + printed, size - printed, "%s%#x", printed ? "|" : "", flags);



	return printed;

}



#define SCA_PIPE_FLAGS syscall_arg__scnprintf_pipe_flags



static size_t syscall_arg__scnprintf_signum(char *bf, size_t size, struct syscall_arg *arg)

{

	int sig = arg->val;
@@ -620,6 +643,8 @@ static struct syscall_fmt { 
	  .arg_scnprintf = { [2] = SCA_OPEN_FLAGS, /* flags */ }, },

	{ .name	    = "openat",	    .errmsg = true,

	  .arg_scnprintf = { [2] = SCA_OPEN_FLAGS, /* flags */ }, },

	{ .name	    = "pipe2",	    .errmsg = true,

	  .arg_scnprintf = { [1] = SCA_PIPE_FLAGS, /* flags */ }, },

	{ .name	    = "poll",	    .errmsg = true, .timeout = true, },

	{ .name	    = "ppoll",	    .errmsg = true, .timeout = true, },

	{ .name	    = "pread",	    .errmsg = true, .alias = "pread64", },

CRA Git | Maintained and supported by SUSTech CRA and CCSE