Commit 46a7574c authored May 24, 2009 by Jeff Layton Committed by Steve French May 26, 2009

cifs: fix artificial limit on reading symlinks



There's no reason to limit the size of a symlink that we can read to
4000 bytes. That may be nowhere near PATH_MAX if the server is sending
UCS2 strings. CIFS should be able to read in a symlink up to the size of
the buffer. The size of the header has already been accounted for when
creating the slabcache, so CIFSMaxBufSize should be the correct size to
pass in.

Fixes samba bug #6384.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent e2a1b9ee

fs/cifs/cifssmb.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2427,8 +2427,7 @@ querySymLinkRetry:
		params = 2 /* level / + 4 / rsrvd / + name_len / incl null */ ;
		pSMB->TotalDataCount = 0;
		pSMB->MaxParameterCount = cpu_to_le16(2);
		/* BB find exact max data count below from sess structure BB */
		pSMB->MaxDataCount = cpu_to_le16(4000);
		pSMB->MaxDataCount = cpu_to_le16(CIFSMaxBufSize);
		pSMB->MaxSetupCount = 0;
		pSMB->Reserved = 0;
		pSMB->Flags = 0;

Admin message