Commit 46a16959 authored May 24, 2019 by Jakub Kicinski Committed by David S. Miller May 26, 2019

net/tls: fix lowat calculation if some data came from previous record



If some of the data came from the previous record, i.e. from
the rx_list it had already been decrypted, so it's not counted
towards the "decrypted" variable, but the "copied" variable.
Take that into account when checking lowat.

When calculating lowat target we need to pass the original len.
E.g. if lowat is at 80, len is 100 and we had 30 bytes on rx_list
target would currently be incorrectly calculated as 70, even though
we only need 50 more bytes to make up the 80.

Fixes: 692d7b5d ("tls: Fix recvmsg() to be able to peek across multiple records")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Tested-by: David Beckett <david.beckett@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 66a04abf

net/tls/tls_sw.c

+6 −7

Original line number	Diff line number	Diff line
		@@ -1712,13 +1712,12 @@ int tls_sw_recvmsg(struct sock *sk,
		copied = err;
		}

		len = len - copied;
		if (len) {
		if (len <= copied)
		goto recv_end;

		target = sock_rcvlowat(sk, flags & MSG_WAITALL, len);
		len = len - copied;
		timeo = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
		} else {
		goto recv_end;
		}

		do {
		bool retain_skb = false;
		@@ -1853,7 +1852,7 @@ pick_next_record:
		}

		/* If we have a new message from strparser, continue now. */
		if (decrypted >= target && !ctx->recv_pkt)
		if (decrypted + copied >= target && !ctx->recv_pkt)
		break;
		} while (len);

Admin message