Commit 469f87e1 authored Jun 15, 2017 by Haishuang Yan Committed by David S. Miller Jun 16, 2017

ip_tunnel: fix potential issue in ip_tunnel_rcv



When ip_tunnel_rcv fails, the tun_dst won't be freed, so call
dst_release to free it in error code path.

Fixes: 2e15ea39 ("ip_gre: Add support to collect tunnel metadata.")
Acked-by: Eric Dumazet <edumazet@google.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Tested-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent be56a099

net/ipv4/ip_tunnel.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -446,6 +446,8 @@ int ip_tunnel_rcv(struct ip_tunnel tunnel, struct sk_buff skb,
		return 0;

		drop:
		if (tun_dst)
		dst_release((struct dst_entry *)tun_dst);
		kfree_skb(skb);
		return 0;
		}

Admin message