Commit 469d6d06 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

tty: Remove unused drop() method from tty_port interface 



Although originally conceived as a hook for port drivers to know
when a port reference is dropped, no driver uses this method.

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e3bfea23

drivers/tty/tty_port.c

+1 −5
Original line number Diff line number Diff line
@@ -484,8 +484,6 @@ int tty_port_close_start(struct tty_port *port, 


	if (port->count) {

		spin_unlock_irqrestore(&port->lock, flags);

		if (port->ops->drop)

			port->ops->drop(port);

		return 0;

	}

	set_bit(ASYNCB_CLOSING, &port->flags);
@@ -504,9 +502,7 @@ int tty_port_close_start(struct tty_port *port, 
	/* Flush the ldisc buffering */

	tty_ldisc_flush(tty);



	/* Don't call port->drop for the last reference. Callers will want

	   to drop the last active reference in ->shutdown() or the tty

	   shutdown path */

	/* Report to caller this is the last port reference */

	return 1;

}

EXPORT_SYMBOL(tty_port_close_start);

include/linux/tty.h

+0 −1
Original line number Diff line number Diff line
@@ -180,7 +180,6 @@ struct tty_port_operations { 
	   IFF the port was initialized. Do not use to free resources. Called

	   under the port mutex to serialize against activate/shutdowns */

	void (*shutdown)(struct tty_port *port);

	void (*drop)(struct tty_port *port);

	/* Called under the port mutex from tty_port_open, serialized using

	   the port mutex */

        /* FIXME: long term getting the tty argument *out* of this would be

CRA Git | Maintained and supported by SUSTech CRA and CCSE