Commit 46936fd6 authored May 22, 2017 by Arnd Bergmann Committed by Andy Shevchenko May 23, 2017

platform/x86: ideapad-laptop: hide unused 'touchpad_store'

A readonly sysfs property must not have a 'store' function:

drivers/platform/x86/ideapad-laptop.c:438:16: error: 'touchpad_store' defined but not used [-Werror=unused-function]

We can either comment it out or remove the function entirely,
without a good reason one or or another I picked the second option.

Fixes: 7f363145 ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent 23ccd036

drivers/platform/x86/ideapad-laptop.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -435,7 +435,8 @@ static ssize_t touchpad_show(struct device *dev,
		return sprintf(buf, "%lu\n", result);
		}

		static ssize_t touchpad_store(struct device *dev,
		/* Switch to RO for now: It might be revisited in the future */
		static ssize_t __maybe_unused touchpad_store(struct device *dev,
		struct device_attribute *attr,
		const char *buf, size_t count)
		{
		@@ -453,7 +454,6 @@ static ssize_t touchpad_store(struct device *dev,
		return count;
		}

		/* Switch to RO for now: It might be revisited in the future */
		static DEVICE_ATTR_RO(touchpad);

		static struct attribute *ideapad_attributes[] = {

Admin message