Commit 46833a86 authored Feb 24, 2014 by Mike Pecovnik Committed by David S. Miller Feb 25, 2014

net: Fix permission check in netlink_connect()



netlink_sendmsg() was changed to prevent non-root processes from sending
messages with dst_pid != 0.
netlink_connect() however still only checks if nladdr->nl_groups is set.
This patch modifies netlink_connect() to check for the same condition.

Signed-off-by: Mike Pecovnik <mike.pecovnik@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 687d705c

net/netlink/af_netlink.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1489,8 +1489,8 @@ static int netlink_connect(struct socket sock, struct sockaddr addr,
		if (addr->sa_family != AF_NETLINK)
		return -EINVAL;

		/* Only superuser is allowed to send multicasts */
		if (nladdr->nl_groups && !netlink_capable(sock, NL_CFG_F_NONROOT_SEND))
		if ((nladdr->nl_groups \|\| nladdr->nl_pid) &&
		!netlink_capable(sock, NL_CFG_F_NONROOT_SEND))
		return -EPERM;

		if (!nlk->portid)

Admin message