Commit 4652edb7 authored Mar 06, 2014 by Ying Xue Committed by David S. Miller Mar 06, 2014

tipc: fix connection refcount leak



When tipc_conn_sendmsg() calls tipc_conn_lookup() to query a
connection instance, its reference count value is increased if
it's found. But subsequently if it's found that the connection is
closed, the work of sending message is not queued into its server
send workqueue, and the connection reference count is not decreased.
This will cause a reference count leak. To reproduce this problem,
an application would need to open and closes topology server
connections with high intensity.

We fix this by immediately decrementing the connection reference
count if a send fails due to the connection being closed.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Acked-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6d4ebeb4

net/tipc/server.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -427,10 +427,12 @@ int tipc_conn_sendmsg(struct tipc_server *s, int conid,
		list_add_tail(&e->list, &con->outqueue);
		spin_unlock_bh(&con->outqueue_lock);

		if (test_bit(CF_CONNECTED, &con->flags))
		if (test_bit(CF_CONNECTED, &con->flags)) {
		if (!queue_work(s->send_wq, &con->swork))
		conn_put(con);

		} else {
		conn_put(con);
		}
		return 0;
		}

Admin message