Commit 464e86da authored Feb 28, 2019 by Julian Wiedmann Committed by David S. Miller Feb 28, 2019

s390/qeth: remove a redundant check for card->dev



smatch complains that __qeth_l3_set_offline() first accesses card->dev,
and then later checks whether the pointer is valid.
Since commit d3d1b205 ("s390/qeth: allocate netdevice early"), the
pointer is _always_ valid - that patch merely missed to remove this one
check.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d4560150

drivers/s390/net/qeth_l3_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2414,7 +2414,7 @@ static int __qeth_l3_set_offline(struct ccwgroup_device *cgdev,
		rtnl_unlock();

		qeth_l3_stop_card(card);
		if ((card->options.cq == QETH_CQ_ENABLED) && card->dev) {
		if (card->options.cq == QETH_CQ_ENABLED) {
		rtnl_lock();
		call_netdevice_notifiers(NETDEV_REBOOT, card->dev);
		rtnl_unlock();

Admin message