power: supply: cros_usbpd: Remove dev_err() getting the number of ports (464aca16) · Commits · 戴 / test

When a device has no support to get the charger number of ports, it doesn't have to result in a dev_err(), print saying "Could not get charger port count" using a dev_info() would suffice. In such case, the dev_info() message is already printed but the dev_err() is annoying, specially, on those devices that doesn't support the command. So remove the dev_err(). Signed-off-by:

Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by:

Guenter Roeck <groeck@chromium.org> Signed-off-by:

Sebastian Reichel <sebastian.reichel@collabora.com>

drivers/power/supply/cros_usbpd-charger.c

+2 −8

Original line number	Original line	Diff line number	Diff line
	@@ -132,11 +132,8 @@ static int cros_usbpd_charger_get_num_ports(struct charger_data *charger)
	ret = cros_usbpd_charger_ec_command(charger, 0,		ret = cros_usbpd_charger_ec_command(charger, 0,
	EC_CMD_CHARGE_PORT_COUNT,		EC_CMD_CHARGE_PORT_COUNT,
	NULL, 0, &resp, sizeof(resp));		NULL, 0, &resp, sizeof(resp));
	if (ret < 0) {		if (ret < 0)
	dev_err(charger->dev,
	"Unable to get the number of ports (err:0x%x)\n", ret);
	return ret;		return ret;
	}

	return resp.port_count;		return resp.port_count;
	}		}
	@@ -148,11 +145,8 @@ static int cros_usbpd_charger_get_usbpd_num_ports(struct charger_data *charger)

	ret = cros_usbpd_charger_ec_command(charger, 0, EC_CMD_USB_PD_PORTS,		ret = cros_usbpd_charger_ec_command(charger, 0, EC_CMD_USB_PD_PORTS,
	NULL, 0, &resp, sizeof(resp));		NULL, 0, &resp, sizeof(resp));
	if (ret < 0) {		if (ret < 0)
	dev_err(charger->dev,
	"Unable to get the number or ports (err:0x%x)\n", ret);
	return ret;		return ret;
	}

	return resp.num_ports;		return resp.num_ports;
	}		}

Admin message