Commit 4649079b authored by Steven Rostedt (VMware)'s avatar Steven Rostedt (VMware)
Browse files

tracing: Make ftrace packed events have align of 1 

When using trace-cmd on 5.6-rt for the function graph tracer, the output was
corrupted. It gave output like this:

 funcgraph_entry:       func=0xffffffff depth=38982
 funcgraph_entry:       func=0x1ffffffff depth=16044
 funcgraph_exit:        func=0xffffffff overrun=0x92539aaf00000000 calltime=0x92539c9900000072 rettime=0x100000072 depth=11084
 funcgraph_exit:        func=0xffffffff overrun=0x9253946e00000000 calltime=0x92539e2100000072 rettime=0x72 depth=26033702
 funcgraph_entry:       func=0xffffffff depth=85798
 funcgraph_entry:       func=0x1ffffffff depth=12044

The reason was because the tracefs/events/ftrace/funcgraph_entry/exit format
file was incorrect. The -rt kernel adds more common fields to the trace
events. Namely, common_migrate_disable and common_preempt_lazy_count. Each
is one byte in size. This changes the alignment of the normal payload. Most
events are aligned normally, but the function and function graph events are
defined with a "PACKED" macro, that packs their payload. As the offsets
displayed in the format files are now calculated by an aligned field, the
aligned field for function and function graph events should be 1, not their
normal alignment.

With aligning of the funcgraph_entry event, the format file has:

        field:unsigned short common_type;       offset:0;       size:2; signed:0;
        field:unsigned char common_flags;       offset:2;       size:1; signed:0;
        field:unsigned char common_preempt_count;       offset:3;       size:1; signed:0;
        field:int common_pid;   offset:4;       size:4; signed:1;
        field:unsigned char common_migrate_disable;     offset:8;       size:1; signed:0;
        field:unsigned char common_preempt_lazy_count;  offset:9;       size:1; signed:0;

        field:unsigned long func;       offset:16;      size:8; signed:0;
        field:int depth;        offset:24;      size:4; signed:1;

But the actual alignment is:

	field:unsigned short common_type;	offset:0;	size:2;	signed:0;
	field:unsigned char common_flags;	offset:2;	size:1;	signed:0;
	field:unsigned char common_preempt_count;	offset:3;	size:1;	signed:0;
	field:int common_pid;	offset:4;	size:4;	signed:1;
	field:unsigned char common_migrate_disable;	offset:8;	size:1;	signed:0;
	field:unsigned char common_preempt_lazy_count;	offset:9;	size:1;	signed:0;

	field:unsigned long func;	offset:12;	size:8;	signed:0;
	field:int depth;	offset:20;	size:4;	signed:1;

Link: https://lkml.kernel.org/r/20200609220041.2a3b527f@oasis.local.home



Cc: stable@vger.kernel.org
Fixes: 04ae87a5 ("ftrace: Rework event_create_dir()")
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent 9fbc01cd

kernel/trace/trace.h

+3 −0
Original line number Diff line number Diff line
@@ -61,6 +61,9 @@ enum trace_type { 
#undef __field_desc

#define __field_desc(type, container, item)



#undef __field_packed

#define __field_packed(type, container, item)



#undef __array

#define __array(type, item, size)	type	item[size];

kernel/trace/trace_entries.h

+7 −7
Original line number Diff line number Diff line
@@ -78,8 +78,8 @@ FTRACE_ENTRY_PACKED(funcgraph_entry, ftrace_graph_ent_entry, 


	F_STRUCT(

		__field_struct(	struct ftrace_graph_ent,	graph_ent	)

		__field_desc(	unsigned long,	graph_ent,	func		)

		__field_desc(	int,		graph_ent,	depth		)

		__field_packed(	unsigned long,	graph_ent,	func		)

		__field_packed(	int,		graph_ent,	depth		)

	),



	F_printk("--> %ps (%d)", (void *)__entry->func, __entry->depth)
@@ -92,11 +92,11 @@ FTRACE_ENTRY_PACKED(funcgraph_exit, ftrace_graph_ret_entry, 


	F_STRUCT(

		__field_struct(	struct ftrace_graph_ret,	ret	)

		__field_desc(	unsigned long,	ret,		func	)

		__field_desc(	unsigned long,	ret,		overrun	)

		__field_desc(	unsigned long long, ret,	calltime)

		__field_desc(	unsigned long long, ret,	rettime	)

		__field_desc(	int,		ret,		depth	)

		__field_packed(	unsigned long,	ret,		func	)

		__field_packed(	unsigned long,	ret,		overrun	)

		__field_packed(	unsigned long long, ret,	calltime)

		__field_packed(	unsigned long long, ret,	rettime	)

		__field_packed(	int,		ret,		depth	)

	),



	F_printk("<-- %ps (%d) (start: %llx  end: %llx) over: %d",

kernel/trace/trace_export.c

+16 −0
Original line number Diff line number Diff line
@@ -45,6 +45,9 @@ static int ftrace_event_register(struct trace_event_call *call, 
#undef __field_desc

#define __field_desc(type, container, item)		type item;



#undef __field_packed

#define __field_packed(type, container, item)		type item;



#undef __array

#define __array(type, item, size)			type item[size];
@@ -85,6 +88,13 @@ static void __always_unused ____ftrace_check_##name(void) \ 
	.size = sizeof(_type), .align = __alignof__(_type),		\

	is_signed_type(_type), .filter_type = _filter_type },





#undef __field_ext_packed

#define __field_ext_packed(_type, _item, _filter_type) {	\

	.type = #_type, .name = #_item,				\

	.size = sizeof(_type), .align = 1,			\

	is_signed_type(_type), .filter_type = _filter_type },



#undef __field

#define __field(_type, _item) __field_ext(_type, _item, FILTER_OTHER)
@@ -94,6 +104,9 @@ static void __always_unused ____ftrace_check_##name(void) \ 
#undef __field_desc

#define __field_desc(_type, _container, _item) __field_ext(_type, _item, FILTER_OTHER)



#undef __field_packed

#define __field_packed(_type, _container, _item) __field_ext_packed(_type, _item, FILTER_OTHER)



#undef __array

#define __array(_type, _item, _len) {					\

	.type = #_type"["__stringify(_len)"]", .name = #_item,		\
@@ -129,6 +142,9 @@ static struct trace_event_fields ftrace_event_fields_##name[] = { \ 
#undef __field_desc

#define __field_desc(type, container, item)



#undef __field_packed

#define __field_packed(type, container, item)



#undef __array

#define __array(type, item, len)

CRA Git | Maintained and supported by SUSTech CRA and CCSE