Commit 46483c2e authored Aug 08, 2018 by NeilBrown Committed by Anna Schumaker Aug 08, 2018

NFS: Use an appropriate work queue for direct-write completion



When a direct-write completes, a work_struct is schedule to handle
the completion.
When NFS is being used for swap, the direct write might be a swap-out,
so memory allocation can block until the write completes.
The work queue currently used is not WQ_MEM_RECLAIM, so tasks
can block waiting for memory - this leads to deadlock.

So use nfsiod_workqueue instead.  This will always have a running
thread, and work items should never block waiting for memory.

Signed-off-by: Neil Brown <neilb@suse.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent 72bf75cf

fs/nfs/direct.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -758,7 +758,7 @@ static void nfs_direct_write_schedule_work(struct work_struct *work)

		static void nfs_direct_write_complete(struct nfs_direct_req *dreq)
		{
		schedule_work(&dreq->work); /* Calls nfs_direct_write_schedule_work */
		queue_work(nfsiod_workqueue, &dreq->work); /* Calls nfs_direct_write_schedule_work */
		}

		static void nfs_direct_write_completion(struct nfs_pgio_header *hdr)

Admin message