Commit 4640c7ee authored Feb 13, 2014 by H. Peter Anvin

x86, smap: smap_violation() is bogus if CONFIG_X86_SMAP is off



If CONFIG_X86_SMAP is disabled, smap_violation() tests for conditions
which are incorrect (as the AC flag doesn't matter), causing spurious
faults.

The dynamic disabling of SMAP (nosmap on the command line) is fine
because it disables X86_FEATURE_SMAP, therefore causing the
static_cpu_has() to return false.

Found by Fengguang Wu's test system.

[ v3: move all predicates into smap_violation() ]
[ v2: use IS_ENABLED() instead of #ifdef ]

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Link: http://lkml.kernel.org/r/20140213124550.GA30497@localhost


Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: <stable@vger.kernel.org> # v3.7+

parent 03bbd596

arch/x86/mm/fault.c

+9 −5

Original line number	Diff line number	Diff line
		@@ -1001,6 +1001,12 @@ static int fault_in_kernel_space(unsigned long address)

		static inline bool smap_violation(int error_code, struct pt_regs *regs)
		{
		if (!IS_ENABLED(CONFIG_X86_SMAP))
		return false;

		if (!static_cpu_has(X86_FEATURE_SMAP))
		return false;

		if (error_code & PF_USER)
		return false;

		@@ -1087,12 +1093,10 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code)
		if (unlikely(error_code & PF_RSVD))
		pgtable_bad(regs, error_code, address);

		if (static_cpu_has(X86_FEATURE_SMAP)) {
		if (unlikely(smap_violation(error_code, regs))) {
		bad_area_nosemaphore(regs, error_code, address);
		return;
		}
		}

		/*
		* If we're in an interrupt, have no user context or are running

Admin message