Commit 463f2864 authored Sep 21, 2009 by Andy Whitcroft Committed by Linus Torvalds Sep 22, 2009

checkpatch: possible types -- else cannot start a type



An else cannot start a type, it would have to be within a block after the
else.  This can trigger false modifier matching.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent fc0d8d94

scripts/checkpatch.pl

+2 −0

Original line number	Diff line number	Diff line
		@@ -1372,6 +1372,8 @@ sub process {
		# Ignore functions being called
		} elsif ($s =~ /^.\s$Ident\s\(/s) {

		} elsif ($s =~ /^.\s*else\b/s) {

		# declarations always start with types
		} elsif ($prev_values eq 'E' && $s =~ /^.\s(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s$Ident)+?)\b(?:\s+$Sparse)?\s\\s(?:$Ident\|$\[^$]\))(?:\s$Modifier)?\s(?:;\|=\|,\|\()/s) {
		my $type = $1;

Admin message