Commit 4636cf18 authored by David Howells's avatar David Howells
Browse files

afs: Fix some tracing details 



Fix a couple of tracelines to indicate the usage count after the atomic op,
not the usage count before it to be consistent with other afs and rxrpc
trace lines.

Change the wording of the afs_call_trace_work trace ID label from "WORK" to
"QUEUE" to reflect the fact that it's queueing work, not doing work.

Fixes: 341f741f ("afs: Refcount the afs_call struct")
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 498b5776

fs/afs/rxrpc.c

+2 −2
Original line number Diff line number Diff line
@@ -169,7 +169,7 @@ void afs_put_call(struct afs_call *call) 
	int n = atomic_dec_return(&call->usage);

	int o = atomic_read(&net->nr_outstanding_calls);



	trace_afs_call(call, afs_call_trace_put, n + 1, o,

	trace_afs_call(call, afs_call_trace_put, n, o,

		       __builtin_return_address(0));



	ASSERTCMP(n, >=, 0);
@@ -736,7 +736,7 @@ static void afs_wake_up_async_call(struct sock *sk, struct rxrpc_call *rxcall, 


	u = atomic_fetch_add_unless(&call->usage, 1, 0);

	if (u != 0) {

		trace_afs_call(call, afs_call_trace_wake, u,

		trace_afs_call(call, afs_call_trace_wake, u + 1,

			       atomic_read(&call->net->nr_outstanding_calls),

			       __builtin_return_address(0));

include/trace/events/afs.h

+1 −1
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ enum afs_cb_break_reason { 
	EM(afs_call_trace_get,			"GET  ") \

	EM(afs_call_trace_put,			"PUT  ") \

	EM(afs_call_trace_wake,			"WAKE ") \

	E_(afs_call_trace_work,			"WORK ")

	E_(afs_call_trace_work,			"QUEUE")



#define afs_server_traces \

	EM(afs_server_trace_alloc,		"ALLOC    ") \

CRA Git | Maintained and supported by SUSTech CRA and CCSE