Commit 46323655 authored May 19, 2007 by Ilpo Järvinen Committed by David S. Miller May 19, 2007

[TCP] FRTO: Add missing ECN CWR sending to one of the responses



The conservative spurious RTO response did not queue CWR even
though the sending rate was lowered. Whenever reduction happens
regardless of reason, CWR should be sent (forgetting to send it
is not very fatal though).

A better approach would be to queue CWR when one of the sending
rate reducing responses (rate-halving one or this conservative
response) is used already at RTO. Doing that would allow CWR to
be sent along with the two new data segments that are sent
during FRTO. However, it's a bit "racy" because userland could
tune the response sysctl to a more aggressive one in between.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b6ccc67d

net/ipv4/tcp_input.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2608,6 +2608,7 @@ static void tcp_conservative_spur_to_response(struct tcp_sock *tp)
		{
		tp->snd_cwnd = min(tp->snd_cwnd, tp->snd_ssthresh);
		tp->snd_cwnd_cnt = 0;
		TCP_ECN_queue_cwr(tp);
		tcp_moderate_cwnd(tp);
		}

Admin message