Commit 462cfcb4 authored May 19, 2020 by Andy Shevchenko Committed by Wolfram Sang May 22, 2020

i2c: designware: Drop unneeded condition in i2c_dw_validate_speed()



We may bailout directly from the loop instead of breaking it and
testing a loop counter. This also gives advantages such as decreased
indentation level along with dropped unneeded condition.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>

parent 20ee1d90

drivers/i2c/busses/i2c-designware-common.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -127,16 +127,14 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev)
		*/
		for (i = 0; i < ARRAY_SIZE(i2c_dw_supported_speeds); i++) {
		if (t->bus_freq_hz == i2c_dw_supported_speeds[i])
		break;
		return 0;
		}
		if (i == ARRAY_SIZE(i2c_dw_supported_speeds)) {

		dev_err(dev->dev,
		"%d Hz is unsupported, only 100kHz, 400kHz, 1MHz and 3.4MHz are supported\n",
		t->bus_freq_hz);
		return -EINVAL;
		}

		return 0;
		return -EINVAL;
		}
		EXPORT_SYMBOL_GPL(i2c_dw_validate_speed);

Admin message