Commit 462b529f authored by Grant Grundler's avatar Grant Grundler Committed by Kyle McMartin
Browse files

[PARISC] remove global_ack_eiem 



Kudos to Thibaut Varene for spotting the (mis)use of appropriately named
global_ack_eiem. This took a long time to figure out and both insight
from myself, Kyle McMartin, and James Bottomley were required to narrow
down which bit of code could have this race condition.

The symptom was interrupts stopped getting delivered while some workload
was generating IO interrupts on two different CPUs. One of the interrupt
sources would get masked off and stay unmasked. Problem was global_ack_eiem
was accessed with read/modified/write sequence and not protected by
a spinlock.

PA-RISC doesn't need a global ack flag though. External Interrupts
are _always_ delivered to a single CPU (except for "global broadcast
interrupt" which AFAIK currently is not used.) So we don't have to worry
about any given IRQ vector getting delivered to more than one CPU.

Tested on a500 and rp34xx boxen. rsync to/from gsyprf11 (a500)
would lock up the box since NIC (tg3) interrupt and SCSI (sym2)
were on "opposite" CPUs (2 CPU system). Put them on the same CPU
or apply this patch and 10GB of data would rsync completely.

Please apply the following critical patch.

thanks,
grant

Signed-off-by: default avatarGrant Grundler <grundler@parisc-linux.org>
Acked-by: default avatarThibaut VARENE <T-Bone@parisc-linux.org>
Signed-off-by: default avatarKyle McMartin <kyle@parisc-linux.org>
parent c3d4ed4e

arch/parisc/kernel/irq.c

+8 −18
Original line number Diff line number Diff line
@@ -46,14 +46,10 @@ extern irqreturn_t ipi_interrupt(int, void *); 
static volatile unsigned long cpu_eiem = 0;



/*

** ack bitmap ... habitually set to 1, but reset to zero

** local ACK bitmap ... habitually set to 1, but reset to zero

** between ->ack() and ->end() of the interrupt to prevent

** re-interruption of a processing interrupt.

*/

static volatile unsigned long global_ack_eiem = ~0UL;

/*

** Local bitmap, same as above but for per-cpu interrupts

*/

static DEFINE_PER_CPU(unsigned long, local_ack_eiem) = ~0UL;



static void cpu_disable_irq(unsigned int irq)
@@ -94,13 +90,11 @@ void cpu_ack_irq(unsigned int irq) 
	int cpu = smp_processor_id();



	/* Clear in EIEM so we can no longer process */

	if (CHECK_IRQ_PER_CPU(irq_desc[irq].status))

	per_cpu(local_ack_eiem, cpu) &= ~mask;

	else

		global_ack_eiem &= ~mask;



	/* disable the interrupt */

	set_eiem(cpu_eiem & global_ack_eiem & per_cpu(local_ack_eiem, cpu));

	set_eiem(cpu_eiem & per_cpu(local_ack_eiem, cpu));



	/* and now ack it */

	mtctl(mask, 23);

}
@@ -111,13 +105,10 @@ void cpu_end_irq(unsigned int irq) 
	int cpu = smp_processor_id();



	/* set it in the eiems---it's no longer in process */

	if (CHECK_IRQ_PER_CPU(irq_desc[irq].status))

	per_cpu(local_ack_eiem, cpu) |= mask;

	else

		global_ack_eiem |= mask;



	/* enable the interrupt */

	set_eiem(cpu_eiem & global_ack_eiem & per_cpu(local_ack_eiem, cpu));

	set_eiem(cpu_eiem & per_cpu(local_ack_eiem, cpu));

}



#ifdef CONFIG_SMP
@@ -354,8 +345,7 @@ void do_cpu_irq_mask(struct pt_regs *regs) 
	local_irq_disable();

	irq_enter();



	eirr_val = mfctl(23) & cpu_eiem & global_ack_eiem &

		per_cpu(local_ack_eiem, cpu);

	eirr_val = mfctl(23) & cpu_eiem & per_cpu(local_ack_eiem, cpu);

	if (!eirr_val)

		goto set_out;

	irq = eirr_to_irq(eirr_val);
@@ -381,7 +371,7 @@ void do_cpu_irq_mask(struct pt_regs *regs) 
	return;



 set_out:

	set_eiem(cpu_eiem & global_ack_eiem & per_cpu(local_ack_eiem, cpu));

	set_eiem(cpu_eiem & per_cpu(local_ack_eiem, cpu));

	goto out;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE