checkpatch: prefer __section over __attribute__((section(...))) (462811d9) · Commits · 戴 / test

Add another test for __attribute__((section("foo"))) uses that should be __section(foo) Link: http://lkml.kernel.org/r/2f374c3c27054b7f978115270d587c624d9962fc.camel@perches.com Suggested-by:

scripts/checkpatch.pl

+12 −0

Original line number	Diff line number	Diff line
		@@ -5886,6 +5886,18 @@ sub process {
		"__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
		}

		# Check for __attribute__ section, prefer __section
		if ($realfile !~ m@\binclude/uapi/@ &&
		$line =~ /\b__attribute__\s\(\s\(._section_\s\(\s("[^"]")/) {
		my $old = substr($rawline, $-[1], $+[1] - $-[1]);
		my $new = substr($old, 1, -1);
		if (WARN("PREFER_SECTION",
		"__section($new) is preferred over __attribute__((section($old)))\n" . $herecurr) &&
		$fix) {
		$fixed[$fixlinenr] =~ s/\b__attribute__\s$\s\(\s_section_\s\(\s\Q$old\E\s$\s\)\s\)/__section($new)/;
		}
		}

		# Check for __attribute__ format(printf, prefer __printf
		if ($realfile !~ m@\binclude/uapi/@ &&
		$line =~ /\b__attribute__\s\(\s\(\sformat\s\(\s*printf/) {