Commit 4625d752 authored Jun 14, 2017 by Lv Zheng Committed by Rafael J. Wysocki Jun 28, 2017

ACPI: EC: Fix EC command visibility for dynamic debug



acpi_ec_cmd_string() currently is only enabled for "DEBUG" macro, but users
trend to use CONFIG_DYNAMIC_DEBUG and enable ec.c pr_debug() print-outs by
"dyndbg='file ec.c +p'". In this use case, all command names are turned
into UNDEF and the log is confusing. This affects bugzilla triage work.

This patch fixes this issue by enabling acpi_ec_cmd_string() for
CONFIG_DYNAMIC_DEBUG.

Tested-by: Wang Wendy <wendy.wang@intel.com>
Tested-by: Feng Chenzhou <chenzhoux.feng@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 1ab69f27

drivers/acpi/ec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -316,7 +316,7 @@ static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
		ec->timestamp = jiffies;
		}

		#ifdef DEBUG
		#if defined(DEBUG) \|\| defined(CONFIG_DYNAMIC_DEBUG)
		static const char *acpi_ec_cmd_string(u8 cmd)
		{
		switch (cmd) {

Admin message