Commit 46238845 authored Oct 21, 2014 by Johannes Berg Committed by Johannes Berg Oct 30, 2014

mac80211: properly flush delayed scan work on interface removal



When an interface is deleted, an ongoing hardware scan is canceled and
the driver must abort the scan, at the very least reporting completion
while the interface is removed.

However, if it scheduled the work that might only run after everything
is said and done, which leads to cfg80211 warning that the scan isn't
reported as finished yet; this is no fault of the driver, it already
did, but mac80211 hasn't processed it.

To fix this situation, flush the delayed work when the interface being
removed is the one that was executing the scan.

Cc: stable@vger.kernel.org
Reported-by: Sujith Manoharan <sujith@msujith.org>
Tested-by: Sujith Manoharan <sujith@msujith.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent ff1e417c

net/mac80211/iface.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -766,10 +766,12 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata,
		int i, flushed;
		struct ps_data *ps;
		struct cfg80211_chan_def chandef;
		bool cancel_scan;

		clear_bit(SDATA_STATE_RUNNING, &sdata->state);

		if (rcu_access_pointer(local->scan_sdata) == sdata)
		cancel_scan = rcu_access_pointer(local->scan_sdata) == sdata;
		if (cancel_scan)
		ieee80211_scan_cancel(local);

		/*
		@@ -992,6 +994,9 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata,

		ieee80211_recalc_ps(local, -1);

		if (cancel_scan)
		flush_delayed_work(&local->scan_work);

		if (local->open_count == 0) {
		ieee80211_stop_device(local);

Admin message