Commit 461e6c85 authored Apr 25, 2008 by Eric Dumazet Committed by David S. Miller Apr 25, 2008

xfrm: alg_key_len & alg_icv_len should be unsigned

In commit ba749ae9 ([XFRM]: alg_key_len
should be unsigned to avoid integer divides
<http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=ba749ae98d5aa9d2ce9a7facde0deed454f92230

>)
alg_key_len field of struct xfrm_algo was converted to unsigned int to
avoid integer divides.

Then Herbert in commit 1a6509d9
([IPSEC]: Add support for combined mode algorithms) added a new
structure xfrm_algo_aead, that resurrected a signed int for alg_key_len
and re-introduce integer divides.

This patch avoids these divides and saves 64 bytes of text on i386.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5b3f129c

include/linux/xfrm.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -98,8 +98,8 @@ struct xfrm_algo {

		struct xfrm_algo_aead {
		char alg_name[64];
		int alg_key_len; /* in bits */
		int alg_icv_len; /* in bits */
		unsigned int alg_key_len; /* in bits */
		unsigned int alg_icv_len; /* in bits */
		char alg_key[0];
		};

Admin message