Commit 4619ed40 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Doug Ledford
Browse files

RDMA/bnxt_re: Delete unsupported modify_port function 



There is no need to return always zero for function which is not
supported. The IB stack treats uninitialized ib_device->functions as
not implemented.

Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Acked-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 63a5f483

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+0 −17
Original line number Diff line number Diff line
@@ -313,23 +313,6 @@ int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num, 
	return 0;

}



int bnxt_re_modify_port(struct ib_device *ibdev, u8 port_num,

			int port_modify_mask,

			struct ib_port_modify *port_modify)

{

	switch (port_modify_mask) {

	case IB_PORT_SHUTDOWN:

		break;

	case IB_PORT_INIT_TYPE:

		break;

	case IB_PORT_RESET_QKEY_CNTR:

		break;

	default:

		break;

	}

	return 0;

}



int bnxt_re_get_port_immutable(struct ib_device *ibdev, u8 port_num,

			       struct ib_port_immutable *immutable)

{

drivers/infiniband/hw/bnxt_re/ib_verbs.h

+0 −3
Original line number Diff line number Diff line
@@ -141,9 +141,6 @@ int bnxt_re_modify_device(struct ib_device *ibdev, 
			  struct ib_device_modify *device_modify);

int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num,

		       struct ib_port_attr *port_attr);

int bnxt_re_modify_port(struct ib_device *ibdev, u8 port_num,

			int port_modify_mask,

			struct ib_port_modify *port_modify);

int bnxt_re_get_port_immutable(struct ib_device *ibdev, u8 port_num,

			       struct ib_port_immutable *immutable);

int bnxt_re_query_pkey(struct ib_device *ibdev, u8 port_num,

drivers/infiniband/hw/bnxt_re/main.c

+0 −1
Original line number Diff line number Diff line
@@ -474,7 +474,6 @@ static int bnxt_re_register_ib(struct bnxt_re_dev *rdev) 
	ibdev->modify_device		= bnxt_re_modify_device;



	ibdev->query_port		= bnxt_re_query_port;

	ibdev->modify_port		= bnxt_re_modify_port;

	ibdev->get_port_immutable	= bnxt_re_get_port_immutable;

	ibdev->query_pkey		= bnxt_re_query_pkey;

	ibdev->query_gid		= bnxt_re_query_gid;

CRA Git | Maintained and supported by SUSTech CRA and CCSE