sched: nohz: stop passing around unused "ticks" parameter. (46132e3a) · Commits · 戴 / test

The "ticks" parameter was added in commit ("sched: Cure more NO_HZ load average woes") since calc_global_nohz() was called and needed the "ticks" argument. But in commit ("sched: Fix nohz load accounting -- again!") it became unused as the function calc_global_nohz() dropped using "ticks". Fixes: ("sched: Fix nohz load accounting -- again!") Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:

Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/1593628458-32290-1-git-send-email-paul.gortmaker@windriver.com

include/linux/sched/loadavg.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -43,6 +43,6 @@ extern unsigned long calc_load_n(unsigned long load, unsigned long exp,
		#define LOAD_INT(x) ((x) >> FSHIFT)
		#define LOAD_FRAC(x) LOAD_INT(((x) & (FIXED_1-1)) * 100)

		extern void calc_global_load(unsigned long ticks);
		extern void calc_global_load(void);

		#endif /* _LINUX_SCHED_LOADAVG_H */

kernel/sched/loadavg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -347,7 +347,7 @@ static inline void calc_global_nohz(void) { }
		*
		* Called from the global timer code.
		*/
		void calc_global_load(unsigned long ticks)
		void calc_global_load(void)
		{
		unsigned long sample_window;
		long active, delta;

kernel/time/timekeeping.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2193,7 +2193,7 @@ EXPORT_SYMBOL(ktime_get_coarse_ts64);
		void do_timer(unsigned long ticks)
		{
		jiffies_64 += ticks;
		calc_global_load(ticks);
		calc_global_load();
		}

		/**

Admin message