Commit 460e985e authored by Vladimir Oltean's avatar Vladimir Oltean Committed by David S. Miller
Browse files

net: dsa: felix: fix incorrect action offsets for VCAP IS2 



The port mask width was larger than the actual number of ports, and
therefore, all fields following this one were also shifted by the number
of excess bits. But the driver doesn't use the REW_OP, SMAC_REPLACE_ENA
or ACL_ID bits from the action vector, so the bug was inconsequential.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bbc4d71d

drivers/net/dsa/ocelot/felix_vsc9959.c

+6 −6
Original line number Diff line number Diff line
@@ -685,12 +685,12 @@ static struct vcap_field vsc9959_vcap_is2_actions[] = { 
	[VCAP_IS2_ACT_POLICE_ENA]		= {  9,  1},

	[VCAP_IS2_ACT_POLICE_IDX]		= { 10,  9},

	[VCAP_IS2_ACT_POLICE_VCAP_ONLY]		= { 19,  1},

	[VCAP_IS2_ACT_PORT_MASK]		= { 20, 11},

	[VCAP_IS2_ACT_REW_OP]			= { 31,  9},

	[VCAP_IS2_ACT_SMAC_REPLACE_ENA]		= { 40,  1},

	[VCAP_IS2_ACT_RSV]			= { 41,  2},

	[VCAP_IS2_ACT_ACL_ID]			= { 43,  6},

	[VCAP_IS2_ACT_HIT_CNT]			= { 49, 32},

	[VCAP_IS2_ACT_PORT_MASK]		= { 20,  6},

	[VCAP_IS2_ACT_REW_OP]			= { 26,  9},

	[VCAP_IS2_ACT_SMAC_REPLACE_ENA]		= { 35,  1},

	[VCAP_IS2_ACT_RSV]			= { 36,  2},

	[VCAP_IS2_ACT_ACL_ID]			= { 38,  6},

	[VCAP_IS2_ACT_HIT_CNT]			= { 44, 32},

};



static const struct vcap_props vsc9959_vcap_props[] = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE