Commit 4602b88d authored by Kristen Accardi's avatar Kristen Accardi Committed by Linus Torvalds
Browse files

[PATCH] PCI: 6700/6702PXH quirk 



On the 6700/6702 PXH part, a MSI may get corrupted if an ACPI hotplug
driver and SHPC driver in MSI mode are used together.

This patch will prevent MSI from being enabled for the SHPC as part of
an early pci quirk, as well as on any pci device which sets the no_msi
bit.

Signed-off-by: default avatarKristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 208f3d61

drivers/pci/msi.c

+4 −1
Original line number Diff line number Diff line
@@ -453,7 +453,7 @@ static void enable_msi_mode(struct pci_dev *dev, int pos, int type) 
	}

}



static void disable_msi_mode(struct pci_dev *dev, int pos, int type)

void disable_msi_mode(struct pci_dev *dev, int pos, int type)

{

	u16 control;
@@ -699,6 +699,9 @@ int pci_enable_msi(struct pci_dev* dev) 
	if (!pci_msi_enable || !dev)

 		return status;



	if (dev->no_msi)

		return status;



	temp = dev->irq;



	if ((status = msi_init()) < 0)

drivers/pci/pci.h

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ extern int pci_msi_quirk; 
#else

#define pci_msi_quirk 0

#endif



void disable_msi_mode(struct pci_dev *dev, int pos, int type);

extern int pcie_mch_quirk;

extern struct device_attribute pci_dev_attrs[];

extern struct class_device_attribute class_device_attr_cpuaffinity;

drivers/pci/quirks.c

+21 −0
Original line number Diff line number Diff line
@@ -1291,6 +1291,27 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_E7520_MCH, quir 
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_E7320_MCH,	quirk_pcie_mch );

DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_E7525_MCH,	quirk_pcie_mch );





/*

 * It's possible for the MSI to get corrupted if shpc and acpi

 * are used together on certain PXH-based systems.

 */

static void __devinit quirk_pcie_pxh(struct pci_dev *dev)

{

	disable_msi_mode(dev, pci_find_capability(dev, PCI_CAP_ID_MSI),

					PCI_CAP_ID_MSI);

	dev->no_msi = 1;



	printk(KERN_WARNING "PCI: PXH quirk detected, "

		"disabling MSI for SHPC device\n");

}

DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_PXHD_0,	quirk_pcie_pxh);

DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_PXHD_1,	quirk_pcie_pxh);

DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_PXH_0,	quirk_pcie_pxh);

DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_PXH_1,	quirk_pcie_pxh);

DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_PXHV,	quirk_pcie_pxh);





static void __devinit quirk_netmos(struct pci_dev *dev)

{

	unsigned int num_parallel = (dev->subsystem_device & 0xf0) >> 4;

include/linux/pci.h

+2 −1
Original line number Diff line number Diff line
@@ -556,6 +556,7 @@ struct pci_dev { 
	/* keep track of device state */

	unsigned int	is_enabled:1;	/* pci_enable_device has been called */

	unsigned int	is_busmaster:1; /* device is busmaster */

	unsigned int	no_msi:1;	/* device may not use msi */



	u32		saved_config_space[16]; /* config space saved at suspend time */

	struct bin_attribute *rom_attr; /* attribute descriptor for sysfs ROM entry */

include/linux/pci_ids.h

+5 −0
Original line number Diff line number Diff line
@@ -2281,6 +2281,11 @@ 
#define PCI_VENDOR_ID_INTEL		0x8086

#define PCI_DEVICE_ID_INTEL_EESSC	0x0008

#define PCI_DEVICE_ID_INTEL_21145	0x0039

#define PCI_DEVICE_ID_INTEL_PXHD_0	0x0320

#define PCI_DEVICE_ID_INTEL_PXHD_1	0x0321

#define PCI_DEVICE_ID_INTEL_PXH_0	0x0329

#define PCI_DEVICE_ID_INTEL_PXH_1	0x032A

#define PCI_DEVICE_ID_INTEL_PXHV	0x032C

#define PCI_DEVICE_ID_INTEL_82375	0x0482

#define PCI_DEVICE_ID_INTEL_82424	0x0483

#define PCI_DEVICE_ID_INTEL_82378	0x0484

CRA Git | Maintained and supported by SUSTech CRA and CCSE