fs/proc/thread_self.c: code cleanup for proc_setup_thread_self() (45f68ab5) · Commits · 戴 / test

Remove unnecessary ERR_PTR()/PTR_ERR() cast in proc_setup_thread_self(). Link: http://lkml.kernel.org/r/20190124030150.8472-2-cgxu519@gmx.com Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Cc: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by:

fs/proc/thread_self.c

+8 −8

Original line number	Diff line number	Diff line
		@@ -38,6 +38,7 @@ int proc_setup_thread_self(struct super_block *s)
		struct inode *root_inode = d_inode(s->s_root);
		struct pid_namespace *ns = proc_pid_ns(root_inode);
		struct dentry *thread_self;
		int ret = -ENOMEM;

		inode_lock(root_inode);
		thread_self = d_alloc_name(s->s_root, "thread-self");
		@@ -51,20 +52,19 @@ int proc_setup_thread_self(struct super_block *s)
		inode->i_gid = GLOBAL_ROOT_GID;
		inode->i_op = &proc_thread_self_inode_operations;
		d_add(thread_self, inode);
		ret = 0;
		} else {
		dput(thread_self);
		thread_self = ERR_PTR(-ENOMEM);
		}
		} else {
		thread_self = ERR_PTR(-ENOMEM);
		}
		inode_unlock(root_inode);
		if (IS_ERR(thread_self)) {

		if (ret)
		pr_err("proc_fill_super: can't allocate /proc/thread_self\n");
		return PTR_ERR(thread_self);
		}
		else
		ns->proc_thread_self = thread_self;
		return 0;

		return ret;
		}

		void __init proc_thread_self_init(void)