Commit 45e86971 authored Dec 30, 2016 by Arnd Bergmann Committed by Alex Williamson Dec 30, 2016

vfio-pci: use 32-bit comparisons for register address for gcc-4.5



Using ancient compilers (gcc-4.5 or older) on ARM, we get a link
failure with the vfio-pci driver:

ERROR: "__aeabi_lcmp" [drivers/vfio/pci/vfio-pci.ko] undefined!

The reason is that the compiler tries to do a comparison of
a 64-bit range. This changes it to convert to a 32-bit number
explicitly first, as newer compilers do for themselves.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent 99e3123e

drivers/vfio/pci/vfio_pci_rdwr.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -193,7 +193,10 @@ ssize_t vfio_pci_vga_rw(struct vfio_pci_device vdev, char __user buf,
		if (!vdev->has_vga)
		return -EINVAL;

		switch (pos) {
		if (pos > 0xbfffful)
		return -EINVAL;

		switch ((u32)pos) {
		case 0xa0000 ... 0xbffff:
		count = min(count, (size_t)(0xc0000 - pos));
		iomem = ioremap_nocache(0xa0000, 0xbffff - 0xa0000 + 1);

Admin message