Commit 45e093ae authored May 16, 2016 by Richard Alpe Committed by David S. Miller May 16, 2016

tipc: check nl sock before parsing nested attributes



Make sure the socket for which the user is listing publication exists
before parsing the socket netlink attributes.

Prior to this patch a call without any socket caused a NULL pointer
dereference in tipc_nl_publ_dump().

Tested-and-reported-by: Baozeng Ding <sploving1@gmail.com>
Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.cm>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 77f57761

net/tipc/socket.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2853,6 +2853,9 @@ int tipc_nl_publ_dump(struct sk_buff skb, struct netlink_callback cb)
		if (err)
		return err;

		if (!attrs[TIPC_NLA_SOCK])
		return -EINVAL;

		err = nla_parse_nested(sock, TIPC_NLA_SOCK_MAX,
		attrs[TIPC_NLA_SOCK],
		tipc_nl_sock_policy);

Admin message