Commit 45c38973 authored May 29, 2020 by Jon Doron Committed by Paolo Bonzini Jun 01, 2020

x86/kvm/hyper-v: enable hypercalls regardless of hypercall page



Microsoft's kdvm.dll dbgtransport module does not respect the hypercall
page and simply identifies the CPU being used (AMD/Intel) and according
to it simply makes hypercalls with the relevant instruction
(vmmcall/vmcall respectively).

The relevant function in kdvm is KdHvConnectHypervisor which first checks
if the hypercall page has been enabled via HV_X64_MSR_HYPERCALL_ENABLE,
and in case it was not it simply sets the HV_X64_MSR_GUEST_OS_ID to
0x1000101010001 which means:
build_number = 0x0001
service_version = 0x01
minor_version = 0x01
major_version = 0x01
os_id = 0x00 (Undefined)
vendor_id = 1 (Microsoft)
os_type = 0 (A value of 0 indicates a proprietary, closed source OS)

and starts issuing the hypercall without setting the hypercall page.

To resolve this issue simply enable hypercalls also if the guest_os_id
is not 0.

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Jon Doron <arilou@gmail.com>
Message-Id: <20200529134543.1127440-5-arilou@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent f97f5a56

arch/x86/kvm/hyperv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1656,7 +1656,7 @@ ret_success:

		bool kvm_hv_hypercall_enabled(struct kvm *kvm)
		{
		return READ_ONCE(kvm->arch.hyperv.hv_hypercall) & HV_X64_MSR_HYPERCALL_ENABLE;
		return READ_ONCE(kvm->arch.hyperv.hv_guest_os_id) != 0;
		}

		static void kvm_hv_hypercall_set_result(struct kvm_vcpu *vcpu, u64 result)

Admin message