Unverified Commit 45c13803 authored Oct 27, 2019 by Navid Emamdoost Committed by Mark Brown Oct 28, 2019

ASoC: SOF: ipc: Fix memory leak in sof_set_get_large_ctrl_data



In the implementation of sof_set_get_large_ctrl_data() there is a memory
leak in case an error. Release partdata if sof_get_ctrl_copy_params()
fails.

Fixes: 54d198d5 ("ASoC: SOF: Propagate sof_get_ctrl_copy_params() error properly")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Link: https://lore.kernel.org/r/20191027215330.12729-1-navid.emamdoost@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent c0a333d8

sound/soc/sof/ipc.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -572,8 +572,10 @@ static int sof_set_get_large_ctrl_data(struct snd_sof_dev *sdev,
		else
		err = sof_get_ctrl_copy_params(cdata->type, partdata, cdata,
		sparams);
		if (err < 0)
		if (err < 0) {
		kfree(partdata);
		return err;
		}

		msg_bytes = sparams->msg_bytes;
		pl_size = sparams->pl_size;

Admin message