Commit 45bf5cd7 authored Mar 05, 2010 by Andrew Morton Committed by Linus Torvalds Mar 06, 2010

fs/compat_ioctl.c: suppress two warnings



fs/compat_ioctl.c: In function 'do_ioctl_trans':
fs/compat_ioctl.c:534: warning: 'karg' may be used uninitialized in this function
fs/compat_ioctl.c:533: warning: 'kcmd' may be used uninitialized in this function
fs/compat_ioctl.c:656: warning: 'ret' may be used uninitialized in this function

Reduces text size by 44 bytes.

If someone calls one of these functions with an unexpected argument, the
code's buggy as-is.

Amerigo Wang <amwang@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 08564fb7

fs/compat_ioctl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -545,7 +545,7 @@ static int mt_ioctl_trans(unsigned int fd, unsigned int cmd, void __user *argp)
		kcmd = MTIOCPOS;
		karg = &pos;
		break;
		case MTIOCGET32:
		default: /* MTIOCGET32 */
		kcmd = MTIOCGET;
		karg = &get;
		break;
		@@ -663,7 +663,7 @@ static int raw_ioctl(unsigned fd, unsigned cmd,

		switch (cmd) {
		case RAW_SETBIND:
		case RAW_GETBIND: {
		default: { /* RAW_GETBIND */
		struct raw_config_request req;
		mm_segment_t oldfs = get_fs();

Admin message