Commit 45b95608 authored Mar 24, 2009 by Anton Vorontsov Committed by Ingo Molnar Mar 23, 2009

tracing: Fix TRACING_SUPPORT dependency for PPC32



commit 40ada30f ("tracing: clean up menu"),
despite the "clean up" in its purpose, introduced a behavioural
change for Kconfig symbols: we no longer able to select tracing
support on PPC32 (because IRQFLAGS_SUPPORT isn't yet implemented).

The IRQFLAGS_SUPPORT is not mandatory for most tracers, tracing core
has a special case for platforms w/o irqflags (which, by the way, has
become useless as of the commit above).

Though according to Ingo Molnar, there was periodic build failures on
weird, unmaintained architectures that had no irqflags-tracing support
and hence didn't know the raw_irqs_save/restore primitives. Thus we'd
better not enable irqflags-less tracing for all architectures.

This patch restores the old behaviour for PPC32, and thus brings the
tracing back. Other architectures can either add themselves to the
exception list or (better) implement TRACE_IRQFLAGS_SUPPORT.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-b: Steven Rostedt <rostedt@goodmis.org>
Cc: linuxppc-dev@ozlabs.org
LKML-Reference: <20090323220724.GA9851@oksana.dev.rtsoft.ru>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 3e1f60b8

kernel/trace/Kconfig

+5 −1

Original line number	Diff line number	Diff line
		@@ -63,7 +63,11 @@ config TRACING
		#
		config TRACING_SUPPORT
		bool
		depends on TRACE_IRQFLAGS_SUPPORT
		# PPC32 has no irqflags tracing support, but it can use most of the
		# tracers anyway, they were tested to build and work. Note that new
		# exceptions to this list aren't welcomed, better implement the
		# irqflags tracing for your architecture.
		depends on TRACE_IRQFLAGS_SUPPORT \|\| PPC32
		depends on STACKTRACE_SUPPORT
		default y

Admin message