Commit 45b86112 authored Mar 24, 2019 by Jiri Pirko Committed by David S. Miller Mar 24, 2019

net: devlink: disallow port_attrs_set() to be called before register



Since the port attributes are static and cannot change during the port
lifetime, WARN_ON if some driver calls it after registration. Also, no
need to call notifications as it is noop anyway due to check of
devlink_port->registered there.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d8ba3620

net/core/devlink.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -5388,12 +5388,13 @@ void devlink_port_attrs_set(struct devlink_port *devlink_port,
		{
		struct devlink_port_attrs *attrs = &devlink_port->attrs;

		if (WARN_ON(devlink_port->registered))
		return;
		attrs->set = true;
		attrs->flavour = flavour;
		attrs->port_number = port_number;
		attrs->split = split;
		attrs->split_subport_number = split_subport_number;
		devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW);
		}
		EXPORT_SYMBOL_GPL(devlink_port_attrs_set);

Admin message