Commit 45ad7db9 authored Dec 17, 2015 by Linus Walleij

gpio: revert get() to non-errorprogating behaviour



commit e20538b8
("gpio: Propagate errors from chip->get()")
started to propagate errors from the .get() functions since
we can get errors from the infrastructure of e.g. slowbus
GPIO expanders.

However it turns out a bunch of drivers relied on the core
to clamp the value, so we need to revert to the old behaviour
and go over all drivers and fix them to conform to the
expectations of the core before we go back to propagating
the error code.

Cc: stable@vger.kernel.org # 4.3+
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Fixes: e20538b8 ("gpio: Propagate errors from chip->get()")
Reported-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 67a76aaf

drivers/gpio/gpiolib.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -1279,7 +1279,13 @@ static int _gpiod_get_raw_value(const struct gpio_desc *desc)
		chip = desc->chip;
		offset = gpio_chip_hwgpio(desc);
		value = chip->get ? chip->get(chip, offset) : -EIO;
		value = value < 0 ? value : !!value;
		/*
		* FIXME: fix all drivers to clamp to [0,1] or return negative,
		* then change this to:
		* value = value < 0 ? value : !!value;
		* so we can properly propagate error codes.
		*/
		value = !!value;
		trace_gpio_value(desc_to_gpio(desc), 1, value);
		return value;
		}

Admin message