Commit 45a2d646 authored Nov 08, 2019 by Arnd Bergmann Committed by Greg Kroah-Hartman Nov 13, 2019

lp: fix sparc64 LPSETTIMEOUT ioctl



The layout of struct timeval is different on sparc64 from
anything else, and the patch I did long ago failed to take
this into account.

Change it now to handle sparc64 user space correctly again.

Quite likely nobody cares about parallel ports on sparc64,
but there is no reason not to fix it.

Cc: stable@vger.kernel.org
Fixes: 9a450484 ("lp: support 64-bit time_t user space")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20191108203435.112759-7-arnd@arndb.de


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 99817404

drivers/char/lp.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -713,6 +713,10 @@ static int lp_set_timeout64(unsigned int minor, void __user *arg)
		if (copy_from_user(karg, arg, sizeof(karg)))
		return -EFAULT;

		/* sparc64 suseconds_t is 32-bit only */
		if (IS_ENABLED(CONFIG_SPARC64) && !in_compat_syscall())
		karg[1] >>= 32;

		return lp_set_timeout(minor, karg[0], karg[1]);
		}

Admin message