Commit 45942ba8 authored Feb 11, 2020 by Jason A. Donenfeld Committed by David S. Miller Feb 13, 2020

xfrm: interface: use icmp_ndo_send helper

Because xfrmi is calling icmp from network device context, it should use
the ndo helper so that the rate limiting applies correctly.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a12d7f3c

net/xfrm/xfrm_interface.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -300,9 +300,9 @@ xfrmi_xmit2(struct sk_buff skb, struct net_device dev, struct flowi *fl)
		if (mtu < IPV6_MIN_MTU)
		mtu = IPV6_MIN_MTU;

		icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
		icmpv6_ndo_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);
		} else {
		icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
		icmp_ndo_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
		htonl(mtu));
		}

Admin message