Commit 4551666f authored by Wyatt Wood's avatar Wyatt Wood Committed by Alex Deucher
Browse files

drm/amd/display: Add Logging for Gamma Related information 



[Why]
A recent bug showed that logging would be useful in debugging
various gamma issues.

[How]
Add logging in dc.
Fix formatting for easier graphing.

Signed-off-by: default avatarWyatt Wood <wyatt.wood@amd.com>
Reviewed-by: default avatarAnthony Koo <Anthony.Koo@amd.com>
Acked-by: default avatarBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c0057622

drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c

+6 −6
Original line number Diff line number Diff line
@@ -1452,15 +1452,15 @@ static void log_tf(struct dc_context *ctx, 
	DC_LOG_ALL_TF_CHANNELS("Logging all channels...");



	for (i = 0; i < hw_points_num; i++) {

		DC_LOG_GAMMA("R %d %llu\n", i, tf->tf_pts.red[i].value);

		DC_LOG_ALL_TF_CHANNELS("G %d, %llu\n", i, tf->tf_pts.green[i].value);

		DC_LOG_ALL_TF_CHANNELS("B %d, %llu\n", i, tf->tf_pts.blue[i].value);

		DC_LOG_GAMMA("R\t%d\t%llu\n", i, tf->tf_pts.red[i].value);

		DC_LOG_ALL_TF_CHANNELS("G\t%d\t%llu\n", i, tf->tf_pts.green[i].value);

		DC_LOG_ALL_TF_CHANNELS("B\t%d\t%llu\n", i, tf->tf_pts.blue[i].value);

	}



	for (i = hw_points_num; i < MAX_NUM_HW_POINTS; i++) {

		DC_LOG_ALL_GAMMA("R %d %llu\n", i, tf->tf_pts.red[i].value);

		DC_LOG_ALL_TF_CHANNELS("G %d %llu\n", i, tf->tf_pts.green[i].value);

		DC_LOG_ALL_TF_CHANNELS("B %d %llu\n", i, tf->tf_pts.blue[i].value);

		DC_LOG_ALL_GAMMA("R\t%d\t%llu\n", i, tf->tf_pts.red[i].value);

		DC_LOG_ALL_TF_CHANNELS("G\t%d\t%llu\n", i, tf->tf_pts.green[i].value);

		DC_LOG_ALL_TF_CHANNELS("B\t%d\t%llu\n", i, tf->tf_pts.blue[i].value);

	}

}

drivers/gpu/drm/amd/display/modules/color/color_gamma.c

+2 −2
Original line number Diff line number Diff line
@@ -102,10 +102,10 @@ void log_x_points_distribution(struct dal_logger *logger) 
	int i = 0;



	if (logger != NULL) {

		LOG_GAMMA_WRITE("]Log X Distribution\n");

		LOG_GAMMA_WRITE("Log X Distribution\n");



		for (i = 0; i < MAX_HW_POINTS; i++)

			LOG_GAMMA_WRITE("]%llu\n", coordinates_x[i].x.value);

			LOG_GAMMA_WRITE("%llu\n", coordinates_x[i].x.value);

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE