Commit 454c7999 authored May 16, 2012 by Colin Cross Committed by Ingo Molnar May 30, 2012

sched/rt: Fix SCHED_RR across cgroups



task_tick_rt() has an optimization to only reschedule SCHED_RR tasks
if they were the only element on their rq.  However, with cgroups
a SCHED_RR task could be the only element on its per-cgroup rq but
still be competing with other SCHED_RR tasks in its parent's
cgroup.  In this case, the SCHED_RR task in the child cgroup would
never yield at the end of its timeslice.  If the child cgroup
rt_runtime_us was the same as the parent cgroup rt_runtime_us,
the task in the parent cgroup would starve completely.

Modify task_tick_rt() to check that the task is the only task on its
rq, and that the each of the scheduling entities of its ancestors
is also the only entity on its rq.

Signed-off-by: Colin Cross <ccross@android.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1337229266-15798-1-git-send-email-ccross@android.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 29baa747

kernel/sched/rt.c

+10 −5

Original line number	Diff line number	Diff line
		@@ -1985,6 +1985,8 @@ static void watchdog(struct rq rq, struct task_struct p)

		static void task_tick_rt(struct rq rq, struct task_struct p, int queued)
		{
		struct sched_rt_entity *rt_se = &p->rt;

		update_curr_rt(rq);

		watchdog(rq, p);
		@@ -2002,12 +2004,15 @@ static void task_tick_rt(struct rq rq, struct task_struct p, int queued)
		p->rt.time_slice = RR_TIMESLICE;

		/*
		* Requeue to the end of queue if we are not the only element
		* on the queue:
		* Requeue to the end of queue if we (and all of our ancestors) are the
		* only element on the queue
		*/
		if (p->rt.run_list.prev != p->rt.run_list.next) {
		for_each_sched_rt_entity(rt_se) {
		if (rt_se->run_list.prev != rt_se->run_list.next) {
		requeue_task_rt(rq, p, 0);
		set_tsk_need_resched(p);
		return;
		}
		}
		}

Admin message