Commit 454b0289 authored May 26, 2020 by Will Deacon Committed by David S. Miller Jun 02, 2020

sparc32: mm: Don't try to free page-table pages if ctor() fails



The pages backing page-table allocations for SRMMU are allocated via
memblock as part of the "nocache" region initialisation during
srmmu_paging_init() and should not be freed even if a later call to
pgtable_pte_page_ctor() fails.

Remove the broken call to __free_page().

Cc: David S. Miller <davem@davemloft.net>
Cc: Kirill A. Shutemov <kirill@shutemov.name>
Fixes: 1ae9ae5f ("sparc: handle pgtable_page_ctor() fail")
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ee7c7953

arch/sparc/mm/srmmu.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -365,7 +365,6 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)
		return NULL;
		page = pfn_to_page(__nocache_pa((unsigned long)ptep) >> PAGE_SHIFT);
		if (!pgtable_pte_page_ctor(page)) {
		__free_page(page);
		return NULL;
		}
		return ptep;

Admin message