Commit 4547be78 authored by Stanislav Brabec's avatar Stanislav Brabec Committed by Greg Kroah-Hartman
Browse files

serial-core: resume serial hardware with no_console_suspend 



Perform a tricky suspend/resume even with no_console_suspend.

With no_console_suspend, kernel skips serial port suspend/resume and the
serial hardware may remain in undefined state after resume. It actually
happens on devices that don't have BIOS that handle serial
initialization. It makes impossible to use serial console after resume.

Devices affected by this problem include:
Sharp Zaurus devices
Several PXA based ARM embedded boards

The patch does:
- Save the hardware state
- Perform buffer flush in time of its suspend call
- Tell the driver that port is suspended
- But still accept new data
- And keep console hardware in state that allows to send them

It allows to capture late console messages without breaking console
after resume.

This is just a resend of a patch discussed in these threads, as the
patch was not yet applied.

"Possible suspend/resume regression in .32-rc?" (Nov 1-5, 2009, ARM
list, later LKML)

"serial-core: resume serial hardware with no_console_suspend" (Sep
15-Oct 18, 2009, LKML & ARM lists)

Signed-off-by: default avatarStanislav Brabec <sbrabec@suse.cz>
Tested-by: default avatarHaojian Zhuang <haojian.zhuang@gmail.com>
Tested-by: default avatarDaniel Mack <daniel@caiaq.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6d34855d

drivers/serial/serial_core.c

+33 −55
Original line number Diff line number Diff line
@@ -2006,12 +2006,6 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport) 


	mutex_lock(&port->mutex);



	if (!console_suspend_enabled && uart_console(uport)) {

		/* we're going to avoid suspending serial console */

		mutex_unlock(&port->mutex);

		return 0;

	}



	tty_dev = device_find_child(uport->dev, &match, serial_match_port);

	if (device_may_wakeup(tty_dev)) {

		enable_irq_wake(uport->irq);
@@ -2019,12 +2013,14 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport) 
		mutex_unlock(&port->mutex);

		return 0;

	}

	if (console_suspend_enabled || !uart_console(uport))

		uport->suspended = 1;



	if (port->flags & ASYNC_INITIALIZED) {

		const struct uart_ops *ops = uport->ops;

		int tries;



		if (console_suspend_enabled || !uart_console(uport)) {

			set_bit(ASYNCB_SUSPENDED, &port->flags);

			clear_bit(ASYNCB_INITIALIZED, &port->flags);
@@ -2033,6 +2029,7 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport) 
			ops->set_mctrl(uport, 0);

			ops->stop_rx(uport);

			spin_unlock_irq(&uport->lock);

		}



		/*

		 * Wait for the transmitter to empty.
@@ -2047,15 +2044,17 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport) 
			       drv->dev_name,

			       drv->tty_driver->name_base + uport->line);



		if (console_suspend_enabled || !uart_console(uport))

			ops->shutdown(uport);

	}



	/*

	 * Disable the console device before suspending.

	 */

	if (uart_console(uport))

	if (console_suspend_enabled && uart_console(uport))

		console_stop(uport->cons);



	if (console_suspend_enabled || !uart_console(uport))

		uart_change_pm(state, 3);



	mutex_unlock(&port->mutex);
@@ -2073,29 +2072,6 @@ int uart_resume_port(struct uart_driver *drv, struct uart_port *uport) 


	mutex_lock(&port->mutex);



	if (!console_suspend_enabled && uart_console(uport)) {

		/* no need to resume serial console, it wasn't suspended */

		/*

		 * First try to use the console cflag setting.

		 */

		memset(&termios, 0, sizeof(struct ktermios));

		termios.c_cflag = uport->cons->cflag;

		/*

		 * If that's unset, use the tty termios setting.

		 */

		if (termios.c_cflag == 0)

			termios = *state->port.tty->termios;

		else {

			termios.c_ispeed = termios.c_ospeed =

				tty_termios_input_baud_rate(&termios);

			termios.c_ispeed = termios.c_ospeed =

				tty_termios_baud_rate(&termios);

		}

		uport->ops->set_termios(uport, &termios, NULL);

		mutex_unlock(&port->mutex);

		return 0;

	}



	tty_dev = device_find_child(uport->dev, &match, serial_match_port);

	if (!uport->suspended && device_may_wakeup(tty_dev)) {

		disable_irq_wake(uport->irq);
@@ -2121,6 +2097,7 @@ int uart_resume_port(struct uart_driver *drv, struct uart_port *uport) 
		spin_lock_irq(&uport->lock);

		ops->set_mctrl(uport, 0);

		spin_unlock_irq(&uport->lock);

		if (console_suspend_enabled || !uart_console(uport)) {

			ret = ops->startup(uport);

			if (ret == 0) {

				uart_change_speed(state, NULL);
@@ -2137,6 +2114,7 @@ int uart_resume_port(struct uart_driver *drv, struct uart_port *uport) 
				 */

				uart_shutdown(state);

			}

		}



		clear_bit(ASYNCB_SUSPENDED, &port->flags);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE