Commit 453fd2b3 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: drivers: digital output subdevices do not need SDF_READABLE 



The SDF_READABLE flag is not necessary for digital output subdevices. For
consistency, remove this flag from the comedi drivers that set it.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e0025918

drivers/staging/comedi/drivers/adl_pci9111.c

+1 −1
Original line number Diff line number Diff line
@@ -767,7 +767,7 @@ static int pci9111_auto_attach(struct comedi_device *dev, 


	s = &dev->subdevices[3];

	s->type		= COMEDI_SUBD_DO;

	s->subdev_flags	= SDF_READABLE | SDF_WRITABLE;

	s->subdev_flags	= SDF_WRITABLE;

	s->n_chan	= 16;

	s->maxdata	= 1;

	s->range_table	= &range_digital;

drivers/staging/comedi/drivers/amplc_pc263.c

+1 −1
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ static int pc263_attach(struct comedi_device *dev, struct comedi_devconfig *it) 
	s = &dev->subdevices[0];

	/* digital output subdevice */

	s->type = COMEDI_SUBD_DO;

	s->subdev_flags = SDF_READABLE | SDF_WRITABLE;

	s->subdev_flags = SDF_WRITABLE;

	s->n_chan = 16;

	s->maxdata = 1;

	s->range_table = &range_digital;

drivers/staging/comedi/drivers/amplc_pci263.c

+1 −1
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ static int pci263_auto_attach(struct comedi_device *dev, 
	s = &dev->subdevices[0];

	/* digital output subdevice */

	s->type = COMEDI_SUBD_DO;

	s->subdev_flags = SDF_READABLE | SDF_WRITABLE;

	s->subdev_flags = SDF_WRITABLE;

	s->n_chan = 16;

	s->maxdata = 1;

	s->range_table = &range_digital;

drivers/staging/comedi/drivers/cb_pcidas64.c

+1 −1
Original line number Diff line number Diff line
@@ -3868,7 +3868,7 @@ static int setup_subdevices(struct comedi_device *dev) 
	if (thisboard->layout == LAYOUT_64XX) {

		s = &dev->subdevices[3];

		s->type = COMEDI_SUBD_DO;

		s->subdev_flags = SDF_WRITABLE | SDF_READABLE;

		s->subdev_flags = SDF_WRITABLE;

		s->n_chan = 4;

		s->maxdata = 1;

		s->range_table = &range_digital;

drivers/staging/comedi/drivers/das08.c

+1 −1
Original line number Diff line number Diff line
@@ -507,7 +507,7 @@ int das08_common_attach(struct comedi_device *dev, unsigned long iobase) 
	/* do */

	if (thisboard->do_nchan) {

		s->type = COMEDI_SUBD_DO;

		s->subdev_flags = SDF_WRITABLE | SDF_READABLE;

		s->subdev_flags = SDF_WRITABLE;

		s->n_chan = thisboard->do_nchan;

		s->maxdata = 1;

		s->range_table = &range_digital;

CRA Git | Maintained and supported by SUSTech CRA and CCSE