Commit 45223b78 authored Nov 24, 2017 by Corentin Labbe Committed by Herbert Xu Nov 29, 2017

crypto: arm64/aes - do not call crypto_unregister_skcipher twice on error



When a cipher fails to register in aes_init(), the error path goes thought
aes_exit() then crypto_unregister_skciphers().
Since aes_exit calls also crypto_unregister_skcipher, this triggers a
refcount_t: underflow; use-after-free.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 9f480fae

arch/arm64/crypto/aes-glue.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -665,6 +665,7 @@ static int __init aes_init(void)

		unregister_simds:
		aes_exit();
		return err;
		unregister_ciphers:
		crypto_unregister_skciphers(aes_algs, ARRAY_SIZE(aes_algs));
		return err;

Admin message