Commit 4505a3ef authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller
Browse files

[BRIDGE]: allow setting hardware address of bridge pseudo-dev 



Some people are using bridging to hide multiple machines from an ISP
that restricts by MAC address. So in that case allow the bridge mac
address to be set to any of the existing interfaces.  I don't want to
allow any arbitrary value and confuse STP.

Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fbe9cc4a

net/bridge/br_device.c

+26 −2
Original line number Diff line number Diff line
@@ -15,7 +15,8 @@ 


#include <linux/kernel.h>

#include <linux/netdevice.h>

#include <linux/module.h>

#include <linux/etherdevice.h>



#include <asm/uaccess.h>

#include "br_private.h"
@@ -82,6 +83,29 @@ static int br_change_mtu(struct net_device *dev, int new_mtu) 
	return 0;

}



/* Allow setting mac address of pseudo-bridge to be same as

 * any of the bound interfaces

 */

static int br_set_mac_address(struct net_device *dev, void *p)

{

	struct net_bridge *br = netdev_priv(dev);

	struct sockaddr *addr = p;

	struct net_bridge_port *port;

	int err = -EADDRNOTAVAIL;



	spin_lock_bh(&br->lock);

	list_for_each_entry(port, &br->port_list, list) {

		if (!compare_ether_addr(port->dev->dev_addr, addr->sa_data)) {

			br_stp_change_bridge_id(br, addr->sa_data);

			err = 0;

			break;

		}

	}

	spin_unlock_bh(&br->lock);



	return err;

}



void br_dev_setup(struct net_device *dev)

{

	memset(dev->dev_addr, 0, ETH_ALEN);
@@ -98,6 +122,6 @@ void br_dev_setup(struct net_device *dev) 
	SET_MODULE_OWNER(dev);

	dev->stop = br_dev_stop;

	dev->tx_queue_len = 0;

	dev->set_mac_address = NULL;

	dev->set_mac_address = br_set_mac_address;

	dev->priv_flags = IFF_EBRIDGE;

}

net/bridge/br_private.h

+1 −0
Original line number Diff line number Diff line
@@ -201,6 +201,7 @@ extern void br_stp_disable_bridge(struct net_bridge *br); 
extern void br_stp_enable_port(struct net_bridge_port *p);

extern void br_stp_disable_port(struct net_bridge_port *p);

extern void br_stp_recalculate_bridge_id(struct net_bridge *br);

extern void br_stp_change_bridge_id(struct net_bridge *br, const unsigned char *a);

extern void br_stp_set_bridge_priority(struct net_bridge *br,

				       u16 newprio);

extern void br_stp_set_port_priority(struct net_bridge_port *p,

net/bridge/br_stp_if.c

+1 −2
Original line number Diff line number Diff line
@@ -120,8 +120,7 @@ void br_stp_disable_port(struct net_bridge_port *p) 
}



/* called under bridge lock */

static void br_stp_change_bridge_id(struct net_bridge *br, 

				    const unsigned char *addr)

void br_stp_change_bridge_id(struct net_bridge *br, const unsigned char *addr)

{

	unsigned char oldaddr[6];

	struct net_bridge_port *p;

CRA Git | Maintained and supported by SUSTech CRA and CCSE