sysfs: fix problems with binary files (4503efd0) · Commits · 戴 / test

Some sysfs binary files don't like having 0 passed to them as a size. Fix this up at the root by just returning to the vfs if userspace asks us for a zero sized buffer. Thanks to Pavel Roskin for pointing this out. Reported-by:

Pavel Roskin <proski@gnu.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@suse.de>

fs/sysfs/bin.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -63,6 +63,9 @@ read(struct file file, char __user userbuf, size_t bytes, loff_t *off)
		int count = min_t(size_t, bytes, PAGE_SIZE);
		char *temp;

		if (!bytes)
		return 0;

		if (size) {
		if (offs > size)
		return 0;
		@@ -131,6 +134,9 @@ static ssize_t write(struct file file, const char __user userbuf,
		int count = min_t(size_t, bytes, PAGE_SIZE);
		char *temp;

		if (!bytes)
		return 0;

		if (size) {
		if (offs > size)
		return 0;

Admin message