Unverified Commit 45004d66 authored Jul 22, 2019 by Wenwen Wang Committed by Mark Brown Jul 22, 2019

ASoC: dapm: fix a memory leak bug

In snd_soc_dapm_new_control_unlocked(), a kernel buffer is allocated in
dapm_cnew_widget() to hold the new dapm widget. Then, different actions are
taken according to the id of the widget, i.e., 'w->id'. If any failure
occurs during this process, snd_soc_dapm_new_control_unlocked() should be
terminated by going to the 'request_failed' label. However, the allocated
kernel buffer is not freed on this code path, leading to a memory leak bug.

To fix the above issue, free the buffer before returning from
snd_soc_dapm_new_control_unlocked() through the 'request_failed' label.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Link: https://lore.kernel.org/r/1563803864-2809-1-git-send-email-wang6495@umn.edu

Signed-off-by: Mark Brown <broonie@kernel.org>

parent 62ec3d13

sound/soc/soc-dapm.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3704,6 +3704,8 @@ request_failed:
		dev_err(dapm->dev, "ASoC: Failed to request %s: %d\n",
		w->name, ret);

		kfree_const(w->sname);
		kfree(w);
		return ERR_PTR(ret);
		}

Admin message