Commit 45002267 authored by Ilya Dryomov's avatar Ilya Dryomov
Browse files

crush: ensuring at most num-rep osds are selected 



Crush temporary buffers are allocated as per replica size configured
by the user.  When there are more final osds (to be selected as per
rule) than the replicas, buffer overlaps and it causes crash.  Now, it
ensures that at most num-rep osds are selected even if more number of
osds are allowed by the rule.

Reflects ceph.git commits 6b4d1aa99718e3b367496326c1e64551330fabc0,
                          234b066ba04976783d15ff2abc3e81b6cc06fb10.

Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 9be6df21

net/ceph/crush/mapper.c

+12 −4
Original line number Diff line number Diff line
@@ -289,6 +289,7 @@ static int is_out(const struct crush_map *map, 
 * @type: the type of item to choose

 * @out: pointer to output vector

 * @outpos: our position in that vector

 * @out_size: size of the out vector

 * @tries: number of attempts to make

 * @recurse_tries: number of attempts to have recursive chooseleaf make

 * @local_retries: localized retries
@@ -303,6 +304,7 @@ static int crush_choose_firstn(const struct crush_map *map, 
			       const __u32 *weight, int weight_max,

			       int x, int numrep, int type,

			       int *out, int outpos,

			       int out_size,

			       unsigned int tries,

			       unsigned int recurse_tries,

			       unsigned int local_retries,
@@ -321,6 +323,7 @@ static int crush_choose_firstn(const struct crush_map *map, 
	int item = 0;

	int itemtype;

	int collide, reject;

	int count = out_size;



	dprintk("CHOOSE%s bucket %d x %d outpos %d numrep %d tries %d recurse_tries %d local_retries %d local_fallback_retries %d parent_r %d\n",

		recurse_to_leaf ? "_LEAF" : "",
@@ -328,7 +331,7 @@ static int crush_choose_firstn(const struct crush_map *map, 
		tries, recurse_tries, local_retries, local_fallback_retries,

		parent_r);



	for (rep = outpos; rep < numrep; rep++) {

	for (rep = outpos; rep < numrep && count > 0 ; rep++) {

		/* keep trying until we get a non-out, non-colliding item */

		ftotal = 0;

		skip_rep = 0;
@@ -402,7 +405,7 @@ static int crush_choose_firstn(const struct crush_map *map, 
							 map->buckets[-1-item],

							 weight, weight_max,

							 x, outpos+1, 0,

							 out2, outpos,

							 out2, outpos, count,

							 recurse_tries, 0,

							 local_retries,

							 local_fallback_retries,
@@ -462,6 +465,7 @@ reject: 
		dprintk("CHOOSE got %d\n", item);

		out[outpos] = item;

		outpos++;

		count--;

	}



	dprintk("CHOOSE returns %d\n", outpos);
@@ -653,6 +657,7 @@ int crush_do_rule(const struct crush_map *map, 
	__u32 step;

	int i, j;

	int numrep;

	int out_size;

	/*

	 * the original choose_total_tries value was off by one (it

	 * counted "retries" and not "tries").  add one.
@@ -760,6 +765,7 @@ int crush_do_rule(const struct crush_map *map, 
						x, numrep,

						curstep->arg2,

						o+osize, j,

						result_max-osize,

						choose_tries,

						recurse_tries,

						choose_local_retries,
@@ -769,11 +775,13 @@ int crush_do_rule(const struct crush_map *map, 
						c+osize,

						0);

				} else {

					out_size = ((numrep < (result_max-osize)) ?

                                                    numrep : (result_max-osize));

					crush_choose_indep(

						map,

						map->buckets[-1-w[i]],

						weight, weight_max,

						x, numrep, numrep,

						x, out_size, numrep,

						curstep->arg2,

						o+osize, j,

						choose_tries,
@@ -782,7 +790,7 @@ int crush_do_rule(const struct crush_map *map, 
						recurse_to_leaf,

						c+osize,

						0);

					osize += numrep;

					osize += out_size;

				}

			}

CRA Git | Maintained and supported by SUSTech CRA and CCSE