Commit 44eda784 authored by Ellen Wang's avatar Ellen Wang Committed by Jiri Kosina
Browse files

HID: cp2112: support i2c write-read transfers in hid-cp2112 



cp2112_i2c_xfer() only supports a single i2c_msg.  More than
one message at a time just returns EIO.  This breaks certain
important cases.  For example, the at24 eeprom driver generates
paired write and read messages (for eeprom address and data).

Since the device doesn't support i2c repeated starts in general,
but does support a single write-repeated-start-read pair
(since hardware rev 1), we recognize the latter case and
implement only that.

Signed-off-by: default avatarEllen Wang <ellen@cumulusnetworks.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 5ddfb12e

drivers/hid/hid-cp2112.c

+55 −19
Original line number Original line Diff line number Diff line
@@ -156,6 +156,7 @@ struct cp2112_device { 
	wait_queue_head_t wait;

	wait_queue_head_t wait;

	u8 read_data[61];

	u8 read_data[61];

	u8 read_length;

	u8 read_length;

	u8 hwversion;

	int xfer_status;

	int xfer_status;

	atomic_t read_avail;

	atomic_t read_avail;

	atomic_t xfer_avail;

	atomic_t xfer_avail;
@@ -446,6 +447,24 @@ static int cp2112_i2c_write_req(void *buf, u8 slave_address, u8 *data, 
	return data_length + 3;

	return data_length + 3;

}

}





static int cp2112_i2c_write_read_req(void *buf, u8 slave_address,

				     u8 *addr, int addr_length,

				     int read_length)

{

	struct cp2112_write_read_req_report *report = buf;



	if (read_length < 1 || read_length > 512 ||

	    addr_length > sizeof(report->target_address))

		return -EINVAL;



	report->report = CP2112_DATA_WRITE_READ_REQUEST;

	report->slave_address = slave_address << 1;

	report->length = cpu_to_be16(read_length);

	report->target_address_length = addr_length;

	memcpy(report->target_address, addr, addr_length);

	return addr_length + 5;

}



static int cp2112_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,

static int cp2112_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,

			   int num)

			   int num)

{

{
@@ -453,26 +472,46 @@ static int cp2112_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, 
	struct hid_device *hdev = dev->hdev;

	struct hid_device *hdev = dev->hdev;

	u8 buf[64];

	u8 buf[64];

	ssize_t count;

	ssize_t count;

	ssize_t read_length = 0;

	u8 *read_buf = NULL;

	unsigned int retries;

	unsigned int retries;

	int ret;

	int ret;





	hid_dbg(hdev, "I2C %d messages\n", num);

	hid_dbg(hdev, "I2C %d messages\n", num);





	if (num != 1) {

	if (num == 1) {

		if (msgs->flags & I2C_M_RD) {

			hid_dbg(hdev, "I2C read %#04x len %d\n",

				msgs->addr, msgs->len);

			read_length = msgs->len;

			read_buf = msgs->buf;

			count = cp2112_read_req(buf, msgs->addr, msgs->len);

		} else {

			hid_dbg(hdev, "I2C write %#04x len %d\n",

				msgs->addr, msgs->len);

			count = cp2112_i2c_write_req(buf, msgs->addr,

						     msgs->buf, msgs->len);

		}

		if (count < 0)

			return count;

	} else if (dev->hwversion > 1 &&  /* no repeated start in rev 1 */

		   num == 2 &&

		   msgs[0].addr == msgs[1].addr &&

		   !(msgs[0].flags & I2C_M_RD) && (msgs[1].flags & I2C_M_RD)) {

		hid_dbg(hdev, "I2C write-read %#04x wlen %d rlen %d\n",

			msgs[0].addr, msgs[0].len, msgs[1].len);

		read_length = msgs[1].len;

		read_buf = msgs[1].buf;

		count = cp2112_i2c_write_read_req(buf, msgs[0].addr,

				msgs[0].buf, msgs[0].len, msgs[1].len);

		if (count < 0)

			return count;

	} else {

		hid_err(hdev,

		hid_err(hdev,

			"Multi-message I2C transactions not supported\n");

			"Multi-message I2C transactions not supported\n");

		return -EOPNOTSUPP;

		return -EOPNOTSUPP;

	}

	}





	if (msgs->flags & I2C_M_RD)

		count = cp2112_read_req(buf, msgs->addr, msgs->len);

	else

		count = cp2112_i2c_write_req(buf, msgs->addr, msgs->buf,

					     msgs->len);



	if (count < 0)

		return count;



	ret = hid_hw_power(hdev, PM_HINT_FULLON);

	ret = hid_hw_power(hdev, PM_HINT_FULLON);

	if (ret < 0) {

	if (ret < 0) {

		hid_err(hdev, "power management error: %d\n", ret);

		hid_err(hdev, "power management error: %d\n", ret);
@@ -508,11 +547,8 @@ static int cp2112_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, 
		goto power_normal;

		goto power_normal;

	}

	}





	if (!(msgs->flags & I2C_M_RD))

	for (count = 0; count < read_length;) {

		goto finish;

		ret = cp2112_read(dev, read_buf + count, read_length - count);



	for (count = 0; count < msgs->len;) {

		ret = cp2112_read(dev, msgs->buf + count, msgs->len - count);

		if (ret < 0)

		if (ret < 0)

			goto power_normal;

			goto power_normal;

		if (ret == 0) {

		if (ret == 0) {
@@ -521,7 +557,7 @@ static int cp2112_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, 
			goto power_normal;

			goto power_normal;

		}

		}

		count += ret;

		count += ret;

		if (count > msgs->len) {

		if (count > read_length) {

			/*

			/*

			 * The hardware returned too much data.

			 * The hardware returned too much data.

			 * This is mostly harmless because cp2112_read()

			 * This is mostly harmless because cp2112_read()
@@ -531,15 +567,14 @@ static int cp2112_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, 
			 * it shouldn't go unnoticed.

			 * it shouldn't go unnoticed.

			 */

			 */

			hid_err(hdev, "long read: %d > %zd\n",

			hid_err(hdev, "long read: %d > %zd\n",

				ret, msgs->len - count + ret);

				ret, read_length - count + ret);

			ret = -EIO;

			ret = -EIO;

			goto power_normal;

			goto power_normal;

		}

		}

	}

	}





finish:

	/* return the number of transferred messages */

	/* return the number of transferred messages */

	ret = 1;

	ret = num;





power_normal:

power_normal:

	hid_hw_power(hdev, PM_HINT_NORMAL);

	hid_hw_power(hdev, PM_HINT_NORMAL);
@@ -1047,6 +1082,7 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	dev->adap.dev.parent	= &hdev->dev;

	dev->adap.dev.parent	= &hdev->dev;

	snprintf(dev->adap.name, sizeof(dev->adap.name),

	snprintf(dev->adap.name, sizeof(dev->adap.name),

		 "CP2112 SMBus Bridge on hiddev%d", hdev->minor);

		 "CP2112 SMBus Bridge on hiddev%d", hdev->minor);

	dev->hwversion = buf[2];

	init_waitqueue_head(&dev->wait);

	init_waitqueue_head(&dev->wait);





	hid_device_io_start(hdev);

	hid_device_io_start(hdev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE