drivers/block/loop.c: ratelimit error messages (44bd70c3) · Commits · 戴 / test

Metric tons of high speed spew is not helpful when things go pear shaped. systemd lost its mind, forgot how to stop services it insists on being sole manager of, massive printk() flood ensued, box eventually died. [16206.684000] loop: Write error at byte offset 11412291584, length 4096. [16206.684000] systemd-journald[1758]: /dev/kmsg buffer overrun, some messages lost. [16206.684000] loop: Write error at byte offset 13155434496, length 4096. [16206.684000] loop: Write error at byte offset 13155438592, length 4096. [16206.684000] loop: Write error at byte offset 13155442688, length 4096. [16206.684000] loop: Write error at byte offset 13960736768, length 4096. [16206.684000] loop: Write error at byte offset 14229172224, length 4096. [16206.684000] systemd-journald[1758]: /dev/kmsg buffer overrun, some messages lost. [16206.684000] loop: Write error at byte offset 14766043136, length 4096. [16206.684000] loop: Write error at byte offset 15034478592, length 4096. [16206.684000] systemd-journald[1758]: /dev/kmsg buffer overrun, some messages lost. Signed-off-by:

Mike Galbraith <bitbucket@online.de> Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Jens Axboe <axboe@fb.com>

drivers/block/loop.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -237,7 +237,7 @@ static int __do_lo_send_write(struct file *file,
		file_end_write(file);
		if (likely(bw == len))
		return 0;
		printk(KERN_ERR "loop: Write error at byte offset %llu, length %i.\n",
		printk_ratelimited(KERN_ERR "loop: Write error at byte offset %llu, length %i.\n",
		(unsigned long long)pos, len);
		if (bw >= 0)
		bw = -EIO;
		@@ -277,7 +277,7 @@ static int do_lo_send_write(struct loop_device lo, struct bio_vec bvec,
		return __do_lo_send_write(lo->lo_backing_file,
		page_address(page), bvec->bv_len,
		pos);
		printk(KERN_ERR "loop: Transfer error at byte offset %llu, "
		printk_ratelimited(KERN_ERR "loop: Transfer error at byte offset %llu, "
		"length %i.\n", (unsigned long long)pos, bvec->bv_len);
		if (ret > 0)
		ret = -EIO;
		@@ -316,7 +316,7 @@ static int lo_send(struct loop_device lo, struct bio bio, loff_t pos)
		out:
		return ret;
		fail:
		printk(KERN_ERR "loop: Failed to allocate temporary page for write.\n");
		printk_ratelimited(KERN_ERR "loop: Failed to allocate temporary page for write.\n");
		ret = -ENOMEM;
		goto out;
		}
		@@ -345,7 +345,7 @@ lo_splice_actor(struct pipe_inode_info pipe, struct pipe_buffer buf,
		size = p->bsize;

		if (lo_do_transfer(lo, READ, page, buf->offset, p->page, p->offset, size, IV)) {
		printk(KERN_ERR "loop: transfer error block %ld\n",
		printk_ratelimited(KERN_ERR "loop: transfer error block %ld\n",
		page->index);
		size = -EINVAL;
		}

Admin message